Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add draft JOSS paper #513

Merged
merged 19 commits into from
Mar 11, 2024

Conversation

MFraters
Copy link
Member

@MFraters MFraters commented Sep 9, 2023

This is a WIP pull request for the JOSS paper I am writing on the Geodynamic World Builder.

@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.19%. Comparing base (a8702f7) to head (917e210).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #513      +/-   ##
==========================================
- Coverage   98.24%   98.19%   -0.06%     
==========================================
  Files         107      107              
  Lines        7464     7465       +1     
==========================================
- Hits         7333     7330       -3     
- Misses        131      135       +4     

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8702f7...917e210. Read the comment docs.

@MFraters MFraters force-pushed the add_draft_JOSS_paper branch from 8ae5bac to d045dca Compare September 9, 2023 19:02
@github-actions
Copy link

github-actions bot commented Sep 9, 2023

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 1.019 ± 0.006 (s=424) 1.019 ± 0.005 (s=461) -0.1% .. +0.1%
Slab interpolation curved simple none 1.016 ± 0.004 (s=448) 1.017 ± 0.006 (s=440) -0.0% .. +0.2%
Spherical slab interpolation simple none 1.171 ± 0.007 (s=385) 1.172 ± 0.009 (s=386) -0.1% .. +0.2%
Slab interpolation simple curved CMS 1.058 ± 0.005 (s=432) 1.061 ± 0.004 (s=420) +0.2% .. +0.4%
Spherical slab interpolation simple CMS 1.557 ± 0.011 (s=294) 1.556 ± 0.009 (s=287) -0.2% .. +0.1%
Spherical fault interpolation simple none 1.175 ± 0.006 (s=362) 1.176 ± 0.006 (s=406) -0.1% .. +0.2%
Cartesian min max surface 2.301 ± 0.024 (s=188) 2.304 ± 0.019 (s=205) -0.2% .. +0.5%
Spherical min max surface 7.226 ± 0.029 (s=58) 7.222 ± 0.020 (s=69) -0.3% .. +0.2%

@MFraters MFraters force-pushed the add_draft_JOSS_paper branch 4 times, most recently from 32c2d01 to b6c6c7e Compare September 9, 2023 23:43
@MFraters MFraters force-pushed the add_draft_JOSS_paper branch from d7fb1c6 to efdaf64 Compare February 23, 2024 21:15
doc/JOSS/1.0/paper.md Outdated Show resolved Hide resolved
doc/JOSS/1.0/paper.md Outdated Show resolved Hide resolved
@MFraters MFraters force-pushed the add_draft_JOSS_paper branch 5 times, most recently from 91aa779 to db44497 Compare March 6, 2024 20:56
@gassmoeller
Copy link
Contributor

I added some suggestions in MFraters#12

@MFraters MFraters force-pushed the add_draft_JOSS_paper branch 2 times, most recently from 1b1793c to 6788379 Compare March 10, 2024 02:22
@MFraters MFraters force-pushed the add_draft_JOSS_paper branch from 6788379 to 96f262e Compare March 10, 2024 19:11
@MFraters MFraters added the ready to merge Pull request is ready to merge. May be waiting for tests to complete or other reviews. label Mar 10, 2024
@MFraters MFraters merged commit c547b29 into GeodynamicWorldBuilder:main Mar 11, 2024
34 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull request is ready to merge. May be waiting for tests to complete or other reviews.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants